Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge Baggage #1927

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Bridge Baggage #1927

merged 3 commits into from
Dec 18, 2020

Conversation

mateuszrzeszutek
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek commented Dec 17, 2020 •
edited
Loading

Resolves #973

This turned out to be much smaller than I expected

trask
trask approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

...io/opentelemetry/javaagent/instrumentation/opentelemetryapi/context/AgentContextStorage.java Outdated Show resolved Hide resolved
instrumentation/opentelemetry-api-1.0/javaagent/src/test/groovy/ContextBridgeTest.groovy Outdated Show resolved Hide resolved
instrumentation/opentelemetry-api-1.0/javaagent/src/test/groovy/ContextBridgeTest.groovy Outdated Show resolved Hide resolved
instrumentation/opentelemetry-api-1.0/javaagent/src/test/groovy/ContextBridgeTest.groovy Outdated Show resolved Hide resolved
anuraaga and others added 2 commits December 18, 2020 12:26
@anuraaga @trask
Apply suggestions from code review
36834c2 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@anuraaga @trask
Update instrumentation/opentelemetry-api-1.0/javaagent/src/test/groov…
801882b 
…y/ContextBridgeTest.groovy

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@anuraaga anuraaga merged commit 8f095cb into open-telemetry:master Dec 18, 2020
anuraaga
anuraaga reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - forgot to add my check mark, but LGTM

@mateuszrzeszutek mateuszrzeszutek deleted the bridge-baggage branch February 5, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga left review comments

@trask trask trask approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bridge Baggage
3 participants
@mateuszrzeszutek @anuraaga @trask