end to end latency benchmark #1935
Conversation
bhautikpip
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
| import org.testcontainers.utility.MountableFile; | ||
|
|
||
| public class E2EAgentBenchmark { | ||
| private static String app = System.getenv("APP_IMAGE"); |
There was a problem hiding this comment.
| private static String app = System.getenv("APP_IMAGE"); | |
| private static final String APP_NAME = System.getenv("APP_IMAGE", "ghcr.io/open-telemetry/java-test-containers:smoke-springboot-jdk8-20201204.400701583"); |
There was a problem hiding this comment.
Sorry I did not understand this suggestion. System.gentenv() accepts 1 String param right?
There was a problem hiding this comment.
Oops - sorry System.getenv().getOrDefault
| } | ||
|
|
||
| private void runBenchmark() throws Exception { | ||
| if (app == null || app.equals("")) { |
There was a problem hiding this comment.
Can remove these lines with above suggestion
| exporters: | ||
| - logging |
There was a problem hiding this comment.
can we leave out the exporter, or is there a no-op exporter? in hopes of reducing the impact of running a local collector on the benchmark
There was a problem hiding this comment.
I couldn't find no-op exporter in here. Wouldn't leaving out exporter throws some weird exceptions on the terminal? Since we are not exporting any data out from collector.
There was a problem hiding this comment.
I haven't tried running collector without any exporters :) But if it throws errors when there's no exporter defined than using logging seems reasonable.
| exporters: | ||
| - logging |
There was a problem hiding this comment.
I haven't tried running collector without any exporters :) But if it throws errors when there's no exporter defined than using logging seems reasonable.
|
Thanks @bhautikpip! |
Using wrk (HTTP benchmarking) end to end latency benchmark for any sample app configured with agent and collector setup with receiver. I am also planning to add support for collecting cpu and memory data using oshi instrumentation probably in next PR.
Inspired from this server integrated benchmark: https://github.com/openzipkin/zipkin/blob/master/benchmarks/src/test/java/zipkin2/server/ServerIntegratedBenchmark.java