Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camel instrumentation to set client context property #2042

Merged
merged 1 commit into from Jan 14, 2021
Merged

camel instrumentation to set client context property #2042

merged 1 commit into from Jan 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2021

Closes #2041

  • Apache Camel instrumentation setting CLIENT context prop for "Outbound" spans
  • Rest test modified to reflect this - no more duplicated Client spans!

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to my untrained eye.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more duplicated Client spans!

nice 👍

@mateuszrzeszutek mateuszrzeszutek merged commit b8ef938 into open-telemetry:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache Camel instrumentation should set client span context property
4 participants