tweak the output of the logging exporter: #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jkwatson
commented
Jan 14, 2021
jkwatson
commented
- one span per line
- delineate the span name from the rest of the data
* one span per line * delineate the span name from the rest of the data
jkwatson
requested review from
anuraaga,
iNikem,
mateuszrzeszutek,
trask and
tylerbenson
as code owners
anuraaga
reviewed
Jan 14, 2021
| @@ -25,13 +25,14 @@ public LoggingExporter(String prefix) { | |||
| public CompletableResultCode export(Collection<SpanData> list) { | |||
| StringBuilder stringBuilder = new StringBuilder(); | |||
| for (SpanData span : list) { | |||
|
|
|||
| stringBuilder.setLength(0); | |||
There was a problem hiding this comment.
Ouch, heh.
Are you interested in deleting this to switch to the SDK exporter?
There was a problem hiding this comment.
anything that gets us one span per line would be good for me. ;)
trask
approved these changes
Jan 15, 2021
anuraaga
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.