JMS instrumentation: do not create spans if no messages are received #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages are received Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
malafeev
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
breedx-splk
approved these changes
Jan 21, 2021
| destination = MessageDestination.UNKNOWN; | ||
| } | ||
| // Do not create span when no message is received | ||
| return; | ||
| } else { |
There was a problem hiding this comment.
Not a huge deal, but my preference is to remove the redundant else when there is a return above it.
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
anuraaga
approved these changes
Jan 22, 2021
…-instrumentation into jms-no-message
trask
approved these changes
Jan 22, 2021
iNikem
suggested changes
Jan 22, 2021
| @Advice.Enter long startTime, | ||
| @Advice.Return Message message, | ||
| @Advice.Thrown Throwable throwable) { | ||
| MessageDestination destination; | ||
| if (message == null) { | ||
| destination = |
There was a problem hiding this comment.
JmsSessionInstrumentation can be removed now, right?
added 2 commits
January 22, 2021 20:47
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
iNikem
approved these changes
Jan 22, 2021
|
looks like ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1989