Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename newBuilder() to builder() #4475

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Conversation

MartinDai
Copy link
Contributor

Part of #4392

Previous PR missed some classes case by that code not formatted

@MartinDai
Copy link
Contributor Author

Can someone help me check why the build failed? And how to fix it.
I just renamed some method's name.

@trask
Copy link
Member

trask commented Oct 22, 2021

Can someone help me check why the build failed? And how to fix it. I just renamed some method's name.

oh ya, that's a tricky one, and CI log is not very helpful. i ran locally and looks like you need to rename also here:

(and associated comment:)

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit d314d76 into open-telemetry:main Oct 23, 2021
@MartinDai
Copy link
Contributor Author

👍

Thanks!

@MartinDai MartinDai deleted the rename-builder branch November 18, 2021 02:21
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* rename `newBuilder()` to `builder()`

* rename `newBuilder()` to `builder()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants