Restlet 2.0 instrumentation #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anosek-an
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
...brary/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/RestletTracingBuilder.java
Outdated
Show resolved
Hide resolved
...ibrary/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/RestletHeadersGetter.java
Outdated
Show resolved
Hide resolved
...t-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/TracingFilter.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Nov 4, 2021
...-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/RestletTracing.java
Outdated
Show resolved
Hide resolved
| implementation(project(":instrumentation:restlet:restlet-2.0:library")) | ||
|
|
||
| testImplementation(project(":instrumentation:restlet:restlet-2.0:testing")) | ||
| testImplementation("org.restlet.jse:org.restlet.ext.jetty:2.0.2") |
There was a problem hiding this comment.
does this work, and avoid needing the resolutionStrategy below?
Suggested change
| testImplementation("org.restlet.jse:org.restlet.ext.jetty:2.0.2") | |
| testLibrary("org.restlet.jse:org.restlet.ext.jetty:2.0.2") | |
| latestDepTestLibrary("org.restlet.jse:org.restlet.ext.jetty:2.+") |
There was a problem hiding this comment.
is the resolutionStrategy below still needed? I think latestDepTestLibrary is supposed to handle that
There was a problem hiding this comment.
Unfortunately it seems that even with testLibrary the wrong engine gets picked up and the resolutionStrategy is still needed.
| library("org.restlet.jse:org.restlet:2.0.2") | ||
|
|
||
| testImplementation(project(":instrumentation:restlet:restlet-2.0:testing")) | ||
| testImplementation("org.restlet.jse:org.restlet.ext.jetty:2.0.2") |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* add restlet 2.0 instrumentation * add restlet 2.0 instrumentation * revies: testLibrary, create RestletInstrumenterFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3661
Most of the code is taken from 1.0 instrumentation. Due to changes in packaging (most importantly
RequestandResponsebeing moved fromorg.restlet.datatoorg.restlet) creating acommonmodule for 1.0 and 2.0 instrumentations was impossible.