Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sql sanitizer: sanitize double quoted strings only in couchbase queries #4615

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Sql sanitizer: sanitize double quoted strings only in couchbase queries #4615

merged 3 commits into from
Nov 10, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Nov 9, 2021

Resolves #4593
While looking at #4595 I started thinking about how we could avoid copying the whole sanitizer and came up with this.

trask
trask approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dboreham can you give this a look over? thx!

...ntation-api/src/main/java/io/opentelemetry/instrumentation/api/db/SqlStatementSanitizer.java Outdated
});
}

private static final class StatementKey {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AutoValue?

dboreham
dboreham approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@dboreham dboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It's what I wanted to do but didn't have the codebase knowledge/time to code up. Thanks!

@trask trask merged commit 625feba into open-telemetry:main Nov 10, 2021
@trask trask mentioned this pull request Nov 10, 2021
Closed
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@laurit @RashmiRam
Sql sanitizer: sanitize double quoted strings only in couchbase queri…
439826c 
…es (open-telemetry#4615)

* Sql sanitizer: sanitize double quotes strings only in couchbase queries

* remove unused method

* use AutoValue
@laurit laurit deleted the sql-sanitizer-double-quote branch July 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@dboreham dboreham dboreham approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlSanitizer removes double-quoted "delimited" table and field names
3 participants
@laurit @trask @dboreham