Add a ClassAndMethod class to Instrumentation API #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Nov 10, 2021
| @@ -384,3 +384,18 @@ dependencies { | |||
| testImplementation(project(":instrumentation:yarpc-1.0:javaagent")) | |||
| } | |||
| ``` | |||
|
|
|||
| ## Why we don't use ByteBuddy @Advice.Origin Method | |||
Comment on lines
+171
to
+173
| // Every usage of @Advice.Origin Method is replaced with a call to Class.getMethod, copy it | ||
| // to local variable so that there would be only one call to Class.getMethod. | ||
| method = originMethod; |
anuraaga
approved these changes
Nov 10, 2021
mateuszrzeszutek
approved these changes
Nov 10, 2021
| @@ -384,3 +384,18 @@ dependencies { | |||
| testImplementation(project(":instrumentation:yarpc-1.0:javaagent")) | |||
| } | |||
| ``` | |||
|
|
|||
| ## Why we don't use ByteBuddy @Advice.Origin Method | |||
There was a problem hiding this comment.
WDYT about moving it to the writing-instrumentation-module file, just below the Associate instrumentation classes with instrumented library classes section? It seems like it'd fit that doc more than this one (since it already describes details of writing an advice class)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
iNikem
approved these changes
Nov 10, 2021
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Add a ClassAndMethod class to Instrumentation API * remove sentence * Update docs/contributing/writing-instrumentation.md Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * address review comment Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4592