Capture exception on finatra controller span #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Nov 18, 2021
|
|
||
| @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class) | ||
| public static void handleException( | ||
| @Advice.Return Response response, @Advice.Argument(1) Throwable throwable) { |
There was a problem hiding this comment.
WDYT about adding returns(named("com.twitter.finagle.http.Response")) to the matcher?
iNikem
approved these changes
Nov 18, 2021
trask
approved these changes
Nov 18, 2021
...rc/main/java/io/opentelemetry/javaagent/instrumentation/finatra/FinatraResponseListener.java
Outdated
Show resolved
Hide resolved
Comment on lines
-68
to
+74
| // Finatra doesn't propagate the stack trace or exception to the instrumentation | ||
| // so the normal errorAttributes() method can't be used | ||
| if (endpoint == EXCEPTION) { | ||
| status StatusCode.ERROR | ||
| errorEvent(Exception, EXCEPTION.body) | ||
| } |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Capture exception on finatra controller span * add return type check * store VirtualField in a static field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1131