Remove LongAdder and ClassValue usages from instrumentation-api #4671
Conversation
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
| private final LongAdder internal = new LongAdder(); | ||
| private final LongAdder consumer = new LongAdder(); | ||
| private final LongAdder producer = new LongAdder(); | ||
| private final AtomicLong server = new AtomicLong(); |
There was a problem hiding this comment.
I think LongAdder is important in normal code. We should have a wrapper around the two types based on classpath check, and can use @IgnoreJreRequirement to allow LongAdder
There was a problem hiding this comment.
AtomicLong counters seem acceptable here since they are only used when agent debug is enabled. Not sure whether we'll need our own high-throughput counters in instrumentation, since typically that kind of work will be delegated to the Metrics API.
There was a problem hiding this comment.
Ah thanks for pointing that out - agree if only when debug is enabled, AtomicLong is fine
| private final LongAdder internal = new LongAdder(); | ||
| private final LongAdder consumer = new LongAdder(); | ||
| private final LongAdder producer = new LongAdder(); | ||
| private final AtomicLong server = new AtomicLong(); |
There was a problem hiding this comment.
AtomicLong counters seem acceptable here since they are only used when agent debug is enabled. Not sure whether we'll need our own high-throughput counters in instrumentation, since typically that kind of work will be delegated to the Metrics API.
|
/easycla |
Resolves #4533