Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http.url handing in vert.x 3 http client #4739

Merged
merged 6 commits into from
Dec 1, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Nov 29, 2021

Resolves #4731

@@ -78,6 +78,11 @@ class VertxHttpClientTest extends HttpClientTest<HttpClientRequest> implements A
false
}

@Override
String nonRoutableAddress() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to check testHttps instead of adding a similar knob?

@trask trask merged commit 313979a into open-telemetry:main Dec 1, 2021
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Fix http.url handing in vert.x 3 http client

* correct version

* fix build

* if https test is disabled use http for non routable aadress test

* if https test is disabled use http for non routable aadress test

* use StringBuilder
@laurit laurit deleted the vertx-3-absolute-uri branch July 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertx http client 3 instrumentation populating relative URL in http.url
4 participants