Split out log4j appender #4907
Merged
Split out log4j appender #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
approved these changes
Dec 15, 2021
iNikem
approved these changes
Dec 15, 2021
| dependencies { | ||
| compileOnly("io.opentelemetry:opentelemetry-sdk-logs") | ||
|
|
||
| library("org.apache.logging.log4j:log4j-core:2.13.2") |
There was a problem hiding this comment.
As nobody in its right mind is going to use this version of log4j, should we just start with 2.16? :)
There was a problem hiding this comment.
ya, I think this is the only instrumentation that targets a "patch" version too, will do this in follow-up 👍
| @@ -3,16 +3,11 @@ plugins { | |||
| } | |||
|
|
|||
| dependencies { | |||
There was a problem hiding this comment.
Should this module include implementation(project("...:log4j-2.13.2:library"))?
There was a problem hiding this comment.
this case is a bit odd. the autoconfigure instrumentation doesn't enable the appender (library) instrumentation. another option is to rename library-autoconfigure to library-context-data.... I'll open an issue to discuss and track
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4780