Update log4j library base version #4914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
update-log4j-library-base-version
branch
from
5a0d2fd
to
1f619bf
Compare
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
approved these changes
Dec 16, 2021
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Update log4j-2.7 javaagent instrumentation to match up through 2.15.0 * Rename log4j 2.13.2 to 2.16 * Update one more location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking this opportunity to improve the weird base version we have for log4j library instrumentation (2.13.2/2.13.3).
Seems safe to assume that users will no longer need library instrumentation for log4j2 versions prior to 2.16.0 (though technically the library instrumentation will still work with 2.13.3+, we are just no longer mentioning or officially supporting that).
Auto-instrumentation still covers 2.7+.