Add support for capturing logback mdc attributes #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
approved these changes
Dec 23, 2021
anuraaga
reviewed
Dec 23, 2021
|
|
||
| public static final LoggingEventMapper INSTANCE = new LoggingEventMapper(); | ||
|
|
||
| private static final Cache<String, AttributeKey<String>> mdcAttributeKeys = Cache.bounded(100); |
There was a problem hiding this comment.
Do you think there'd be a benefit in having a shared cache in an .internal. class in instrumentation-api?
There was a problem hiding this comment.
Created #5003 to discuss/track
jack-berg
approved these changes
Dec 28, 2021
Merged
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Add support for capturing logback mdc attributes * Spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following convention from #4959 (log4j)
Split out the mapper class into
libraryinstrumentation to enable unit testing of it, and we will want logback appender (library) shortly anyways (#4947)