Spring RMI instrumentation #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Jan 12, 2022
.../main/java/io/opentelemetry/javaagent/instrumentation/springrmi/server/ServerSingletons.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/springrmi/server/ServerInstrumentationModule.java
Outdated
Show resolved
Hide resolved
.../main/java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientSingletons.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientInstrumentationModule.java
Outdated
Show resolved
Hide resolved
|
@trask Thanks for the suggestions. I've fixed them and pushed a new commit but EasyCLA seems to be just stuck for me. Why could this be happening? I had already signed it earlier for this PR. |
|
/easycla |
.../java/io/opentelemetry/javaagent/instrumentation/rmi/server/RemoteServerInstrumentation.java
Show resolved
Hide resolved
instrumentation/spring/spring-rmi-4.0/javaagent/src/test/groovy/SpringRmiTest.groovy
Show resolved
Hide resolved
...io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientInstrumentationModule.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientInstrumentation.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientInstrumentation.java
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/springrmi/server/ServerInstrumentation.java
Outdated
Show resolved
Hide resolved
.../main/java/io/opentelemetry/javaagent/instrumentation/springrmi/client/ClientSingletons.java
Outdated
Show resolved
Hide resolved
instrumentation/spring/spring-rmi-4.0/javaagent/src/test/groovy/SpringRmiTest.groovy
Outdated
Show resolved
Hide resolved
|
Thanks for the suggestions @mateuszrzeszutek! I've made the changes. |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Spring RMI instrumentation * Change the order of import statements * remove extra separation in import statements * stylistic changes * Fix groovy rule violations * Formatting changes in groovy file * Spotless fixes and muzzle check version change * Fixed minimum version in filenames and fixed muzzle check * single InstrumentationModule and added context propagation test * Merged singletons, use random port in test and add stricter matchers. * Remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instrumentation for Spring RMI.