Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer library instrumentation #5063

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

mateuszrzeszutek
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek commented Jan 10, 2022

Continuation of #5017

This PR splits out a library instrumentation (and a testing module too). It's probably the last major micrometer PR.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner January 10, 2022 15:33
@mateuszrzeszutek mateuszrzeszutek marked this pull request as draft January 10, 2022 15:33
@mateuszrzeszutek
Copy link
Member Author

This PR looks big, but it mostly moves classes (and tests) around; if you exclude that there are not that many changes here.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@trask
Copy link
Member

trask commented Jan 13, 2022

Sporadic failure on test (11, openj9), merging anyways

@trask trask merged commit 9299567 into open-telemetry:main Jan 13, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the micrometer-4 branch January 13, 2022 10:30
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants