Add http.route to the server span when ServerSpanNaming is updated
#5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 2 commits
January 12, 2022 15:20
anuraaga
reviewed
Jan 13, 2022
| @@ -100,6 +99,7 @@ class RestCamelTest extends AgentInstrumentationSpecification implements RetryOn | |||
| "$SemanticAttributes.NET_PEER_PORT" Long | |||
| "$SemanticAttributes.HTTP_SERVER_NAME" String | |||
| "$SemanticAttributes.NET_TRANSPORT" IP_TCP | |||
| "$SemanticAttributes.HTTP_ROUTE" String | |||
There was a problem hiding this comment.
Shouldn't we assert the value for route?
There was a problem hiding this comment.
Added. Turns out camel isn't using ServerSpanNaming to update the server span name and the route is incorrect -- another TODO added to my list.
anuraaga
approved these changes
Jan 14, 2022
trask
approved these changes
Jan 14, 2022
Comment on lines
-39
to
+43
| assert value =~ expected | ||
| assert value =~ expected, "value '$value' does not match regex '$expected'" | ||
| } else if (expected instanceof Class) { | ||
| assert ((Class) expected).isInstance(value) | ||
| assert ((Class) expected).isInstance(value), "value '$value' is not an instance of $expected.name" | ||
| } else if (expected instanceof Closure) { | ||
| assert ((Closure) expected).call(value) | ||
| assert ((Closure) expected).call(value), "value '$value' fails the passed predicate" |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
open-telemetry#5086) * Add `http.route` to the server span when `ServerSpanNaming` is updated * fix camel tests * fix test compilation failure * assert route in camel instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #442 (which actually mostly resolves that issue, but this still needs a couple of refactorings to look good, so I won't close it until it's all done)
This PR adds
http.routeattribute to spans (no metrics yet; another PR) and introduces several TODOs - I'll track them in #442.