Connect AgentLogEmitterProvider global during OpenTelemetryInstaller #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@breedx-splk I pushed a commit 🤞 |
Excellent, thanks! |
anuraaga
approved these changes
Jan 13, 2022
|
payara smoke test has failed a couple of times, the log file is 600mb full of: I'm going to push a commit to default the instrumentation name to |
mateuszrzeszutek
approved these changes
Jan 13, 2022
laurit
approved these changes
Jan 13, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…pen-telemetry#5088) * during install, hook up the log emitter provider for instrumentation to use. * spotless * Fix tests * Default instrumentation name to ROOT when logger name null/empty Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some challenges around #5048 related to this.
Instrumentation uses the global holder for the log emitter. The
LogEmitterProviderfrom the autoconfigured SDK was not being stitched to the global holder during install time, so instrumentations were not yet able to actually emit logs. This remedies that.I confirmed that this this change allows logs to be exported (when the logs exporter is set).
Thanks to @mateuszrzeszutek for help spelunking to find this disconnect.