SdkTracerProvider auto closed as separate Context Bean (#5124) #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jan 14, 2022
anuraaga
approved these changes
Jan 17, 2022
| @ConditionalOnMissingBean(OpenTelemetry.class) | ||
| public static class OpenTelemetryBeanConfig { | ||
|
|
||
| @Bean(destroyMethod = "close") |
There was a problem hiding this comment.
FWIU, close will be called automatically without needing to set it here
There was a problem hiding this comment.
it looks like there's one other place with destroyMethod = "close", going to merge and I'll send a separate PR to update both spots
mateuszrzeszutek
approved these changes
Jan 17, 2022
This was referenced Jan 20, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing the
SdkTracerProvideras a separate@Beanallows to auto close it together with the Spring-Context. This change also allows to provide a customSdkTracerProviderif desired. If a user intends to simply create a customOpenTelemetryobject with an arbitrarySkdTracerProvidernon of both will be auto created.