End jedis span when operation actually ends #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/easycla |
trask
reviewed
Jan 28, 2022
|
|
||
| private JedisRequestContext() {} | ||
|
|
||
| public static <T> JedisRequestContext<T> start() { |
There was a problem hiding this comment.
maybe something like
- start -> attach
- end -> endIfNotAttached
- close -> detachAndEnd
mateuszrzeszutek
approved these changes
Jan 28, 2022
trask
approved these changes
Feb 1, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* End jedis span when operation actually ends * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5061
Initially I tried to move starting/ending span from just sending the command to the methods that send the command and then wait for the result (similarly to what is attempted in #5072) but gave up on it. Jedis adds new methods too frequently, keeping method to command mappings up to date would be a pain.
This pr does not improve handling of
multi()andpipelined().