Log a warning whenever GlobalOpenTelemetry.set() is called #5264
Conversation
| @Advice.OnMethodEnter(suppress = Throwable.class) | ||
| public static void onEnter() { | ||
| LoggerFactory.getLogger(application.io.opentelemetry.api.GlobalOpenTelemetry.class) | ||
| .warn( |
There was a problem hiding this comment.
maybe info? (which is the javaagent's default log level, so will still get logged)
There was a problem hiding this comment.
I think that warn makes slightly more sense in this case (since the log warns you about incorrect API usage), but I don't really have a strong opinion on this. I'll change that if we decide so.
There was a problem hiding this comment.
my only concern is about users adding the javaagent later to an existing app that was previously manually instrumented, and then they're stuck with this warning message which is not really actionable
let's keep at warn and we can always revisit later
There was a problem hiding this comment.
my only concern is about users adding the javaagent later to an existing app that was previously manually instrumented, and then they're stuck with this warning message which is not really actionable
let's keep at
warnand we can always revisit later
Why not actionable? They can remove their manual usages of GlobalOpenTelemetry.set?
There was a problem hiding this comment.
sorry, I should have been more specific, I was thinking about ops users
I decided to implement this while I still remember about it 😅
CC @jack-berg