Refactor HTTP attributes extractors to use composition over inheritance #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jan 28, 2022
| @@ -64,24 +67,51 @@ public RatpackTracingBuilder addClientAttributeExtractor( | |||
| * | |||
| * @param capturedHttpHeaders An instance of {@link CapturedHttpHeaders} containing the configured | |||
| * HTTP request and response names. | |||
| * @deprecated Use {@link #captureHttpServerHeaders(CapturedHttpHeaders)} instead. | |||
.../io/opentelemetry/javaagent/instrumentation/googlehttpclient/GoogleHttpClientSingletons.java
Outdated
Show resolved
Hide resolved
.../opentelemetry/javaagent/instrumentation/asynchttpclient/v2_0/AsyncHttpClientSingletons.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Jan 28, 2022
.../opentelemetry/javaagent/instrumentation/asynchttpclient/v2_0/AsyncHttpClientSingletons.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/jaxrsclient/v1_1/JaxRsClientSingletons.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/jaxrsclient/v2_0/JaxRsClientSingletons.java
Outdated
Show resolved
Hide resolved
...va/io/opentelemetry/javaagent/instrumentation/jaxrsclient/v2_0/ResteasyClientSingletons.java
Outdated
Show resolved
Hide resolved
...telemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyClientInstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
I agree, I thought it was clearer having the multiple extractors built on top of the getter compared to built on top of another extractor |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…ce (open-telemetry#5267) * Refactor HTTP attributes extractors to use composition over inheritance * Rename remaining variables: *Extractor to *Getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that it's probably better to do that before starting the
http.routerefactorings.HTTP client & server attributes extractors have share a common base class, so it was hard to split them into 2 PRs - that's why this one is so large. Still, ~90% of it is just renaming stuff in instrumentations.