Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish gradle-plugins to Maven Central #5333

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Feb 10, 2022

Also makes sure to target Java 8 bytecode so the plugin doesn't require other builds to be using Java 11

Fixes #5330

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of questions to help my understanding for when things don't go as planned 😂

.github/workflows/release-gradle-plugins.yml Outdated Show resolved Hide resolved
GPG_PASSWORD: ${{ secrets.GPG_PASSWORD }}
with:
# Don't use publishToSonatype since we don't want to publish the marker artifact
arguments: build publishPlugins publishPluginMavenPublicationToSonatypeRepository closeAndReleaseSonatypeStagingRepository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does the publishPluginMavenPublicationToSonatypeRepository task come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nexus publish plugin

afterEvaluate {
publishing {
publications {
named<MavenPublication>("pluginMaven") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does named imply that this task already exists?

Copy link
Contributor Author

@anuraaga anuraaga Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Gradle plugin publish plugin creates it

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@anuraaga anuraaga merged commit aeee5b4 into open-telemetry:main Feb 11, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Publish gradle-plugins to Maven Central

* Update .github/workflows/release-gradle-plugins.yml

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish gradle-plugins to Maven Central
3 participants