Updates to http.server_name #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Feb 14, 2022
| return ((ServiceRequestContext) ctx).config().virtualHost().hostnamePattern(); | ||
| return ((ServiceRequestContext) ctx).config().virtualHost().defaultHostname(); |
There was a problem hiding this comment.
@anuraaga can you ack this change?
Comment on lines
-145
to
+143
| return accessor.getRequestServerName(requestContext.request()); | ||
| public String serverName(ServletRequestContext<REQUEST> requestContext) { | ||
| return null; |
| return request.serverName().toString(); | ||
| public String serverName(Request request) { | ||
| return null; |
anuraaga
approved these changes
Feb 14, 2022
currently we don't set |
ya, probably, opened #5375 to discuss/track |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Updates to http.server_name * Tests * fix * armeria * fix * fix * codenarc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from the spec,
http.server_nameis:The servlet and tomcat instrumentation currently capture
http.server_namebased on HTTP Host (e.g. https://docs.oracle.com/javaee/7/api/javax/servlet/ServletRequest.html#getServerName--), so this PR removes the capturing ofhttp.server_namefor those two instrumentations.The only other instrumentation that captures
http.server_nameis armeria, which does appear to be capturing a configuration-based value.I'm not sure if the one instrumentation justifies keeping
serverName()inHttpServerAttributesGetter?For this PR though, at least it seems the
RESPONSEparameter is not needed forserverName()(and based on the spec definition it doesn't seem like this should be something that we need to wait for theRESPONSEfor), so I have removed theRESPONSEparameter from theserverName()method.