Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Groovy 4 #5532

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Update to Groovy 4 #5532

merged 3 commits into from
Mar 9, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Mar 9, 2022

No description provided.

@laurit laurit requested a review from a team as a code owner March 9, 2022 07:58
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

instrumentation/grails-3.0/javaagent/build.gradle.kts Outdated Show resolved Hide resolved
instrumentation/grails-3.0/javaagent/build.gradle.kts Outdated Show resolved Hide resolved
Comment on lines +90 to +92
// copied from HttpServerTest
// groovy classes in testing-common are compiled with a different groovy version, we don't want
// to use them here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask trask added this to the v1.12.0 milestone Mar 9, 2022
@trask trask merged commit e9c1efe into open-telemetry:main Mar 9, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Update to Groovy 4

* exclude spock from grails tests, update comment

* Update instrumentation/grails-3.0/javaagent/build.gradle.kts

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@laurit laurit deleted the groovy4 branch July 6, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants