Implement "Prometheus mode" for better micrometer->OTel->Prometheus support #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Mar 11, 2022
...java/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryMeterRegistryBuilder.java
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Mar 12, 2022
...c/main/java/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryMeterRegistry.java
Show resolved
Hide resolved
anuraaga
reviewed
Mar 12, 2022
...in/java/io/opentelemetry/instrumentation/micrometer/v1_5/PrometheusModeNamingConvention.java
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
prometheus-mode
branch
from
ba68b39
to
0bfe5bc
Compare
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…upport (open-telemetry#5537) * Implement "Prometheus mode" for better micrometer->OTel->Prometheus support * code review comments * forgot about README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another part of the solution to #5292. It does not completely fix that issue, there are still two problems remaining:
LongTaskTimerdoes not really match any OTel instrument well - we're not using an OTel histogram for it (because OTel histogram is for finished records, while this one is supposed to show the ones still inflight). This one instrument would benefit from Bogdan'sMetricProduceridea, but that's almost impossible to implement as javaagent instrumentation. I don't really have any good idea on how to handle that, so for now we'll have to accept that it's not a perfect shim.I'll copy that PR over to the SDK repo once open-telemetry/opentelemetry-java#4258 is merged.