Add missing InstrumenterBuilder.addRequestListener() #5655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Mar 21, 2022
anuraaga
approved these changes
Mar 22, 2022
mateuszrzeszutek
approved these changes
Mar 22, 2022
| @@ -232,10 +232,11 @@ public void end( | |||
|
|
|||
| if (!requestListeners.isEmpty() || !requestMetricListeners.isEmpty()) { | |||
| long endNanos = getNanos(endTime); | |||
| for (RequestListener requestListener : requestListeners) { | |||
| // TODO (trask) call end in the reverse order that start was called? | |||
There was a problem hiding this comment.
We probably don't have to do that - unlike start(), the end() method cannot modify the context; also, we're passing the timestamp as an argument, so the exact time of invocation should not matter too.
There was a problem hiding this comment.
ya, I just always think of start/end pairs telescoping :)
| requestListener.end(context, attributes, endNanos); | ||
| } | ||
| for (RequestListener requestListener : requestMetricListeners) { | ||
| for (RequestListener requestListener : requestListeners) { |
There was a problem hiding this comment.
Nit: do we actually need two lists of listeners? Can't we merge requestMetricListeners into requestListeners?
There was a problem hiding this comment.
I'll send that in a separate PR b/c it moves the requestListeners to after the span is started (which I think is ok, but I'd like to get eyes specifically on that change)
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5652