Apply micrometer instrumentation to spring-boot-actuator apps #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+28
to
+30
| helperResourceBuilder.registerForAllClassLoaders( | ||
| "io/opentelemetry/javaagent/instrumentation/spring/actuator/OpenTelemetryMeterRegistryAutoConfiguration.class"); |
There was a problem hiding this comment.
I used a bit different way of making that class visible to spring class loaders; maybe it'll be useful in other spring instrumentations too.
(Also, an interesting bit: no need to explicitly pass .classdata here, the AgentClassLoader will add the suffix automatically when it's asked to get a .class resource)
mateuszrzeszutek
force-pushed
the
spring-boot-micrometer
branch
from
7ab033a
to
77a38a6
Compare
No attribution needed. I hereby contribute it to OpenTelemetry under the CLA. |
trask
approved these changes
Mar 22, 2022
javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/HelperResources.java
Outdated
Show resolved
Hide resolved
Comment on lines
+28
to
+30
| helperResourceBuilder.registerForAllClassLoaders( | ||
| "io/opentelemetry/javaagent/instrumentation/spring/actuator/OpenTelemetryMeterRegistryAutoConfiguration.class"); |
...avaagent/instrumentation/spring/actuator/AutoConfigurationImportSelectorInstrumentation.java
Outdated
Show resolved
Hide resolved
|
💯 |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…elemetry#5666) * Apply micrometer instrumentation to spring-boot-actuator apps * fix a bug * code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is heavily based on the ApplicationInsights micrometer instrumentation. @trask should I include some additional attribution in the code?
Resolves #5536