Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows passing an OpenTelemetry instance to registerObservers() methods. #5716

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Allows passing an OpenTelemetry instance to registerObservers() methods. #5716

merged 2 commits into from
Mar 31, 2022

Conversation

jenarros
Copy link
Contributor

Resolves #5715

@jenarros jenarros requested a review from a team as a code owner March 30, 2022 16:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 30, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jenarros / name: Eduardo Narros (c1d75a6)

@jenarros jenarros force-pushed the allow_passing_opentelemetry_instance_to_observers branch from 013921a to af85fb3 Compare March 30, 2022 17:22
anuraaga
anuraaga approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anuraaga anuraaga merged commit 2852d1d into open-telemetry:main Mar 31, 2022
@trask trask mentioned this pull request Mar 31, 2022
Merged
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@jenarros @RashmiRam
Allows passing an OpenTelemetry instance to registerObservers() metho…
632def8 
…ds. (open-telemetry#5716)

* Allows passing an OpenTelemetry instance to registerObservers() methods.

* Deprecated registerObserver methods that were using the GlobalOpenTelemetry instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support passing OpenTelemetry instance to observers
3 participants
@jenarros @anuraaga @trask