Instrumenter instrumentation version and schema url #5752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
commented
Apr 5, 2022
| @@ -116,6 +116,17 @@ The `builder()` method accepts three arguments: | |||
| An `Instrumenter` can be built from several smaller components. The following subsections describe | |||
| all interfaces that can be used to customize an `Instrumenter`. | |||
|
|
|||
| ### Set the instrumentation version and OpenTelemetry schema URL | |||
There was a problem hiding this comment.
CC @theletterf - I've added a new section to the Instrumenter API doc, please take a look at this when you have a moment 🙏
theletterf
reviewed
Apr 5, 2022
trask
approved these changes
Apr 5, 2022
Comment on lines
+307
to
+331
| if (instrumentationVersion != null) { | ||
| meterBuilder.setInstrumentationVersion(instrumentationVersion); | ||
| } | ||
| if (schemaUrl != null) { | ||
| meterBuilder.setSchemaUrl(schemaUrl); | ||
| } |
...api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java
Show resolved
Hide resolved
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
mateuszrzeszutek
force-pushed
the
instrumentation-version-schema
branch
from
3bf0fb2
to
39db85f
Compare
mateuszrzeszutek
commented
Apr 7, 2022
| @@ -116,6 +116,33 @@ The `builder()` method accepts three arguments: | |||
| An `Instrumenter` can be built from several smaller components. The following subsections describe | |||
| all interfaces that can be used to customize an `Instrumenter`. | |||
|
|
|||
| ### Set the instrumentation version and OpenTelemetry schema URL | |||
|
|
|||
| Make sure you always provide the instrumentation library version to the `Instrumenter`. You can do | |||
There was a problem hiding this comment.
@theletterf I've added a few more paragraphs, it'd be great if you could proofread them too 🙏
mateuszrzeszutek
force-pushed
the
instrumentation-version-schema
branch
from
260a4a1
to
b07ec24
Compare
theletterf
reviewed
Apr 7, 2022
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
trask
reviewed
Apr 7, 2022
trask
reviewed
Apr 7, 2022
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
) * Instrumenter instrumentation version and schema url * nullable instrumentation version * Apply suggestions from code review Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com> * reformat * code review comments * instrumentation properties files * Apply suggestions from code review Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com> * code review comments * Apply suggestions from code review Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4333