Update the http.route attribute even for not sampled server spans #5844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Apr 15, 2022
trask
approved these changes
Apr 15, 2022
Comment on lines
-105
to
+107
| // checking isRecording() is a helpful optimization for more expensive suppliers | ||
| // (e.g. Spring MVC instrumentation's HandlerAdapterInstrumentation) | ||
| if (serverSpan == null || !serverSpan.isRecording()) { | ||
| // even if the server span is not sampled, we have to continue - we need to compute the | ||
| // http.route properly so that it can be captured by the server metrics | ||
| if (serverSpan == null) { |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the span is not sampled, the HTTP server metrics still use that attribute.
Fixes #5840