fix NPE for commons-httpclient v3.1 (#5944) #5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Apr 28, 2022
| } | ||
|
|
||
| @Override | ||
| int sendRequest(HttpMethod request, String method, URI uri, Map<String, String> headers) { |
There was a problem hiding this comment.
WDYT about extracting a common base class for this class and CommonsHttpClientTest. I believe this is the only method that is different in them.
There was a problem hiding this comment.
of course this makes sense.
I hope the naming will be fine, otherwise just let me know.
Thank you for reviewing this.
laurit
approved these changes
Apr 28, 2022
mateuszrzeszutek
approved these changes
Apr 28, 2022
|
thanks @dgradecak! |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…etry#5949) * fix NPE for commons-httpclient v3.1 (open-telemetry#5944) * fix NPE for commons-httpclient v3.1 (open-telemetry#5944) - spotless fixes * extracting abstract class with reused code (open-telemetry#5944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a certain combination of parameters when using the javaagent extension for apache-httpclient/apache-httpclient-2.0
throws a NPE