Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude duplicate project classes from inst/ #5957

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Looks like these dependencies excludes were needed after all 馃檲

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner April 29, 2022 09:25
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously they probably would have been harmless. Changing agent class loader to child first breaks when these can be loaded from multiple places.

@mateuszrzeszutek
Copy link
Member Author

Previously they probably would have been harmless. Changing agent class loader to child first breaks when these can be loaded from multiple places.

We'd still want to avoid the duplicates, but yeah, probably the agent CL PR made it fail -- that's a good thing though, we can now be pretty sure we'll detect these kind of duplicates should they happen again.

@laurit laurit merged commit dfa43d7 into open-telemetry:main Apr 29, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the agent-exclude-classes branch April 29, 2022 11:45
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants