Implement vertx-kafka-client instrumentation; batch processing #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mateuszrzeszutek heads up I rebased this after merging #5973 |
trask
approved these changes
May 5, 2022
There was a problem hiding this comment.
Batch processing in Vertx Kafka is a bit strange, you have to set up both batch handler and the regular handler and just make the regular one do nothing (e.g. https://github.com/vert-x3/vertx-kafka-client/blob/4.2/src/test/java/io/vertx/kafka/client/tests/ConsumerTestBase.java#L1281-L1303). We'll get both batch and single record telemetry this way, but that's probably fine I guess?
that is strange, oh well, I'm ok with this behavior, can always revisit
...pentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java
Outdated
Show resolved
Hide resolved
trask
reviewed
May 6, 2022
...pentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java
Outdated
Show resolved
Hide resolved
…n/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…telemetry#5982) * Implement vertx-kafka-client instrumentation; batch processing * try-finally just in case * Add to supported libraries list * Update instrumentation/vertx/vertx-kafka-client-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #5973Resolves #1890 (issue was specifically about context propagation in vertx kafka)
Batch processing in Vertx Kafka is a bit strange, you have to set up both batch handler and the regular handler and just make the regular one do nothing (e.g. https://github.com/vert-x3/vertx-kafka-client/blob/4.2/src/test/java/io/vertx/kafka/client/tests/ConsumerTestBase.java#L1281-L1303). We'll get both batch and single record telemetry this way, but that's probably fine I guess?