Make gRPC metadata available to AttributeExtractors #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantorrie
changed the title
evantorrie
changed the title
|
thx @evantorrie! I sent a PR to your PR with some suggestions to align a bit more with existing tests (evantorrie#6) |
* Suggestions
trask
approved these changes
Jun 2, 2022
...tion/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTest.java
Outdated
Show resolved
Hide resolved
...tion/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
laurit
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6123
I wasn't really sure where to add a test for this, and I don't particularly like the way I've done so. It also doesn't seem to be easy to create a javaagent version of this (I think it would involve creating an Instrumentation extension), so I've restricted the test to just the "library" version of the instrumentation.
Feel free to completely change the test structure.