Aws sdk2 sqs context propagation #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Jun 22, 2022
| "aws.queue.name" "testSdkSqs" | ||
| "aws.requestId" "00000000-0000-0000-0000-000000000000" | ||
| "rpc.system" "aws-api" | ||
| "rpc.service" "Sqs" |
There was a problem hiding this comment.
aws sdk1 uses AmazonSQS for rpc.service
There was a problem hiding this comment.
Interesting we are using rpc spec here instead of https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md. Is there any history on why it does it that way?
mateuszrzeszutek
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3684
Resolves #6160
Implement sqs context propagation as it is implemented for aws sdk1. Tests and helper classes were copied from aws1 and adapted for aws2.