Hikaricp: Avoid registering duplicate metrics #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Jul 14, 2022
...main/java/io/opentelemetry/javaagent/instrumentation/hikaricp/HikariPoolInstrumentation.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Jul 14, 2022
…lemetry/javaagent/instrumentation/hikaricp/HikariPoolInstrumentation.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
mateuszrzeszutek
approved these changes
Jul 15, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
* Hikaricp: Avoid registering duplicate metrics * Update instrumentation/hikaricp-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hikaricp/HikariPoolInstrumentation.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * spotless * Trigger build Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
* Hikaricp: Avoid registering duplicate metrics * Update instrumentation/hikaricp-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hikaricp/HikariPoolInstrumentation.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * spotless * Trigger build Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
* Hikaricp: Avoid registering duplicate metrics * Update instrumentation/hikaricp-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hikaricp/HikariPoolInstrumentation.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * spotless * Trigger build Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setMetricsTrackerFactorymay be called multiple times which will cause us to report the same metrics multiple times which causes warningsSuch warnings can be seen for example when running spring petclinic.
Calling
closeas done in this pr is not completely safe as besides callingcloseon our wrapper it will callcloseon the underlying object for which it would not be called when running without the agent.