Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tracing kafka wrappers with jdk proxies #6457

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Replace tracing kafka wrappers with jdk proxies #6457

merged 1 commit into from
Aug 11, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Aug 10, 2022

Resolves #6432

@laurit laurit requested a review from a team as a code owner August 10, 2022 19:36
trask
trask approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mateuszrzeszutek
mateuszrzeszutek approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@trask trask merged commit cd8489f into open-telemetry:main Aug 11, 2022
@trask
Copy link
Member

trask commented Aug 17, 2022

@laurit any ideas why testLatestDeps didn't catch this issue?

@laurit laurit deleted the kafka-wrapper-proxy branch August 18, 2022 06:41
@laurit
Copy link
Contributor Author

laurit commented Aug 18, 2022

@trask the kafka library instrumentation test that tests wrapping kafka consumer only calls poll on the wrapped consumer. The use case from the issue uses wrapped consumer with kafka streams, we don't have a similar test because we don't have library instrumentation for kafka streams and using just kafka library instrumentation + kafka streams won't give you working tracing.

LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
@laurit @LironKS
Replace tracing kafka wrappers with jdk proxies (open-telemetry#6457)
8bc3259
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
@laurit @LironKS
Replace tracing kafka wrappers with jdk proxies (open-telemetry#6457)
d1c85cb
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
@laurit @LironKS
Replace tracing kafka wrappers with jdk proxies (open-telemetry#6457)
34ab27c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TracingConsumer related exception due to missing currentLag method with Kafka greater than or equal 3.0.0
3 participants
@laurit @trask @mateuszrzeszutek