Remove deprecated code #6501
Merged
Remove deprecated code #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Aug 23, 2022
| AutoConfiguredOpenTelemetrySdkBuilder builder = | ||
| AutoConfiguredOpenTelemetrySdk.builder() | ||
| .setResultAsGlobal(true) | ||
| .addPropertiesSupplier(config::getAllProperties); | ||
| .addPropertiesSupplier(new ConfigurationFileLoader()); |
There was a problem hiding this comment.
Suggested change
| .addPropertiesSupplier(new ConfigurationFileLoader()); | |
| .addPropertiesSupplier(ConfigurationFileLoader::new); |
❓
There was a problem hiding this comment.
Wouldn't that result in a Supplier<Supplier<Map<String, String>>>?
There was a problem hiding this comment.
Yeah, you're right. Ignore me.
| static final String CONFIGURATION_FILE_PROPERTY = "otel.javaagent.configuration-file"; | ||
|
|
||
| @Override | ||
| public Map<String, String> get() { |
There was a problem hiding this comment.
There's a fair amount going on in this method. I think it would be helpful to have some test coverage...but the current structure is a bit harder to test due to the static calls to ConfigPropertiesUtil.getString() and the inline creation of file streams. Still, there are at least 5 untested branches....
There was a problem hiding this comment.
It is actually tested, in ConfigurationFileTest.
trask
approved these changes
Aug 24, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
* Remove deprecated code * unnecessary semicolon * fix distro and extension examples
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
* Remove deprecated code * unnecessary semicolon * fix distro and extension examples
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
* Remove deprecated code * unnecessary semicolon * fix distro and extension examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.