Add Spring Boot service name guesser / ResourceProvider #6516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nope, that's the spring boot autoconfigure starter code -- it's meant to be used instead of the javaagent, as a drop-in spring plugin. It's not included in the javaagent. |
...entelemetry/instrumentation/spring/autoconfigure/resources/SpringBootServiceNameGuesser.java
Outdated
Show resolved
Hide resolved
...lemetry/instrumentation/spring/autoconfigure/resources/SpringBootServiceNameGuesserTest.java
Outdated
Show resolved
Hide resolved
instrumentation/spring/spring-boot-resources/library/build.gradle.kts
Outdated
Show resolved
Hide resolved
...entelemetry/instrumentation/spring/autoconfigure/resources/SpringBootServiceNameGuesser.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Sep 2, 2022
trask
reviewed
Sep 6, 2022
Comment on lines
262
to
263
| * Attempts to use ProcessHandle to get the full commandline of the current process. Will only | ||
| * succeed on java 9+. |
There was a problem hiding this comment.
can we use https://docs.oracle.com/javase/8/docs/api/java/lang/management/RuntimeMXBean.html#getInputArguments-- instead, to get Java 8 support?
There was a problem hiding this comment.
nm, I see this is for getting program args, maybe rename method to attemptGetProgramArgsViaReflection?
EDIT: oh, I see this is "full" commandline, so ignore my rename suggestion, maybe just a little more explicit javadoc to unconfuse those like me?
trask
approved these changes
Sep 6, 2022
...ain/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameGuesser.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameGuesser.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameGuesserTest.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameGuesser.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…ry#6516) * Add spring boot service name guesser. * add encoding * improve commandline handling * move guesser to own module * use readAllBytes which exists in java 8 * spotless * add note and link to spring docs * group for readability * repackage * Apply suggestions from code review Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * code review comments Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…ry#6516) * Add spring boot service name guesser. * add encoding * improve commandline handling * move guesser to own module * use readAllBytes which exists in java 8 * spotless * add note and link to spring docs * group for readability * repackage * Apply suggestions from code review Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * code review comments Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…ry#6516) * Add spring boot service name guesser. * add encoding * improve commandline handling * move guesser to own module * use readAllBytes which exists in java 8 * spotless * add note and link to spring docs * group for readability * repackage * Apply suggestions from code review Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * code review comments Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively the same addition that was over in open-telemetry/opentelemetry-java-contrib#427 and we agreed to move into the main instrumentation repo.
Is this the correct module/location?
This also relates to open-telemetry/opentelemetry-java#4718 because ideally we the guesser introduced in this changeset would not override other, potentially more meaningful
service.namevalues that might have already been set by other components.