Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kafka client metrics to the javaagent instrumentation #6533

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Add kafka client metrics to the javaagent instrumentation #6533

merged 3 commits into from
Sep 13, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #5941

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner September 1, 2022 14:51
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Sep 6, 2022
Closed
@mateuszrzeszutek mateuszrzeszutek linked an issue Sep 6, 2022 that may be closed by this pull request
unable to get Kafka metrics #6549
Closed
@trask
Copy link
Member

trask commented Sep 6, 2022

Closing and re-opening to trigger latest dep tests

@trask trask closed this Sep 6, 2022
@trask trask reopened this Sep 6, 2022
trask
trask reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateuszrzeszutek are these metrics on-by-default?

@mateuszrzeszutek
Copy link
Member Author

Yes, enabled by default.

@trask
Copy link
Member

trask commented Sep 8, 2022

oh, sorry, I meant to bring this up in SIG meeting today, I was unsure whether this should be on by default or not, since these are not spec'd metrics, but I guess we're considering it to be similar to micrometer (which is enabled by default)?

one other related concern is that I didn't see an easy way to disable them (without defining a metrics view)?

@mateuszrzeszutek
Copy link
Member Author

oh, sorry, I meant to bring this up in SIG meeting today, I was unsure whether this should be on by default or not, since these are not spec'd metrics, but I guess we're considering it to be similar to micrometer (which is enabled by default)?

one other related concern is that I didn't see an easy way to disable them (without defining a metrics view)?

I think it probably makes sense to have them enabled by default, since it's a bridge/shim-like instrumentation, like micrometer. Making it easy to turn this off sounds good though, I'll add a property for disabling them 👍

@trask trask merged commit c96a49e into open-telemetry:main Sep 13, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the kafka-metrics-javaagent branch September 13, 2022 09:10
@loicgreffier loicgreffier mentioned this pull request Sep 29, 2022
Closed
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
@LironKS
Add kafka client metrics to the javaagent instrumentation (open-telem…
4f44882 
…etry#6533)

* Add kafka client metrics to the javaagent instrumentation

* Don't override user-set metrics reporter

* Add kafka metric reporter config property
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
@LironKS
Add kafka client metrics to the javaagent instrumentation (open-telem…
92a82aa 
…etry#6533)

* Add kafka client metrics to the javaagent instrumentation

* Don't override user-set metrics reporter

* Add kafka metric reporter config property
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
@LironKS
Add kafka client metrics to the javaagent instrumentation (open-telem…
6624830 
…etry#6533)

* Add kafka client metrics to the javaagent instrumentation

* Don't override user-set metrics reporter

* Add kafka metric reporter config property
@laurit laurit mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@laurit laurit laurit approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to get Kafka metrics Kafka-metrics
4 participants
@mateuszrzeszutek @trask @laurit @jack-berg