Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spring webmvc instrumentation name #6557

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix spring webmvc instrumentation name #6557

merged 1 commit into from
Sep 8, 2022

Conversation

mingchuno
Copy link
Contributor

Should be io.opentelemetry.spring-webmvc-5.3 instead

@mingchuno mingchuno requested a review from a team as a code owner September 8, 2022 09:04
mateuszrzeszutek
mateuszrzeszutek approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mingchuno !

@mateuszrzeszutek mateuszrzeszutek merged commit 61fd14f into open-telemetry:main Sep 8, 2022
@mingchuno mingchuno deleted the fix-spring-webmvc-5.3-instrumentation-name branch September 8, 2022 09:20
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
@mingchuno @LironKS
Fix spring webmvc instrumentation name (open-telemetry#6557)
5cf6d85
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
@mingchuno @LironKS
Fix spring webmvc instrumentation name (open-telemetry#6557)
59b9ee3
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
@mingchuno @LironKS
Fix spring webmvc instrumentation name (open-telemetry#6557)
c670b3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mingchuno @mateuszrzeszutek