Support cgroup v2 #7167
Merged
Support cgroup v2 #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Nov 15, 2022
.../library/src/test/java/io/opentelemetry/instrumentation/resources/ContainerResourceTest.java
Outdated
Show resolved
Hide resolved
.../library/src/test/java/io/opentelemetry/instrumentation/resources/ContainerResourceTest.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #6694.
We've been tracking the update to cgroup version support and want to get ahead of the widespread usage. The surface of the existing
ContainerResourcehas not changed, but its internals have been factored out to two "extractor" utilities -- one that understands cgroup v1 and another for v2. v1 is attempted and, if successful, the result is used. If v1 fails, then theContainerResourcewill fall back to v2.As mentioned in #6694, the approach taken in this PR is borrowed from this SO post combined with local experimentation on docker desktop on a Mac, which already uses cgroup2 v2.