Add instrumentation for opentelemetry-extension-kotlin #7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Nov 30, 2022
instrumentation/opentelemetry-extension-kotlin-1.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
…uild.gradle.kts Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #7124
Our kotlin coroutine instrumentation relies on a shaded copy of
opentelemetry-extension-kotlin. This doesn't work well when application also usesopentelemetry-extension-kotlin, because the shaded and unshaded copy store opentelemery context under different key. This pr attempts to fix this by instrumentingopentelemetry-extension-kotlinprovided by the application so that it would delegate to the one shaded inside the agent.