Fix class file load error when using spring-guice together with sprin… #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-web instrumentation
laurit
reviewed
Dec 19, 2022
...o/opentelemetry/javaagent/instrumentation/springweb/v3_1/SpringWebInstrumentationModule.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Dec 19, 2022
mateuszrzeszutek
pushed a commit
that referenced
this pull request
Jan 2, 2023
In #7447 injected resource is opened with class loader getResourceAsStream. This works only in class loaders where getResourceAsStream delegates to getResource. This is not the case with all class loaders, for example tomcat class loader does not do this. Because of this we also need to instrument class loader getResourceAsStream.
trask
reviewed
Jan 3, 2023
Comment on lines
+35
to
+38
| // make the filter class file loadable by ClassPathResource - in some cases (e.g. spring-guice, | ||
| // see https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7428) Spring | ||
| // might want to read the class file metadata; this line will make the filter class file visible | ||
| // to the bean class loader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g-web instrumentation
Fixes #7428