Rename all methods in all Getters to use the get*() naming scheme
#7619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Jan 19, 2023
Comment on lines
+32
to
+33
| throw new UnsupportedOperationException( | ||
| "This method is deprecated and will be removed in the subsequent release."); |
There was a problem hiding this comment.
what do you think of using this pattern everywhere instead?
Suggested change
| throw new UnsupportedOperationException( | |
| "This method is deprecated and will be removed in the subsequent release."); | |
| return getCodeClass(request); |
There was a problem hiding this comment.
Hmm, this would cause a recursive A->B->A->... situation; where if you forget to implement one of these methods you get a stack overflow error.
mateuszrzeszutek
force-pushed
the
getter-naming
branch
from
dbd944e
to
082d11b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6562
This PR only contains renames; the actual content is in the
*Getterinterfaces, the rest of changes is just IntelliJ doing its job.