Fix some instrumentation scope names #7632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Jan 23, 2023
Comment on lines
+193
to
+195
| // emptyToNull since they are the same at protobuf layer, | ||
| // and allows for simpler verification of InstrumentationScope | ||
| .setVersion(emptyToNull(instrumentationScope.getVersion())) |
This was referenced Jan 24, 2023
trask
changed the title
trask
added a commit
that referenced
this pull request
Jan 24, 2023
The build takes ~2 hours when there are changes to core modules that force re-running of all tests. Ran into the long test times (again) in #7632. This also affects release times since the version bump PR build takes 2 hours to run, and then another 2 hours to run release (or wait 2 hours for CI build to run and update gradle cache).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.