Support slf4j to log4j2 #7656
Merged
Support slf4j to log4j2 #7656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
slf4j-to-log4j2
branch
from
8c42729
to
7ee4189
Compare
| @@ -26,12 +26,62 @@ dependencies { | |||
| } | |||
|
|
|||
| tasks { | |||
| test { | |||
There was a problem hiding this comment.
Nit: WDYT about using the test suites feature instead?
There was a problem hiding this comment.
I think I found a good solution, ptal
trask
force-pushed
the
slf4j-to-log4j2
branch
from
7ee4189
to
e40e685
Compare
mateuszrzeszutek
approved these changes
Feb 6, 2023
| // this is needed for the async logging test | ||
| testImplementation("com.lmax:disruptor:3.4.2") | ||
| } | ||
|
|
||
| tasks.withType<Test>().configureEach { | ||
| systemProperty("testLatestDeps", findProperty("testLatestDeps") as Boolean) |
There was a problem hiding this comment.
Nit: you could extract findProperty("testLatestDeps") as Boolean to a variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.