Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTTP span name extractors #7730

Merged
merged 12 commits into from
Feb 14, 2023
Merged

Update HTTP span name extractors #7730

merged 12 commits into from
Feb 14, 2023

Conversation

mateuszrzeszutek
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner February 3, 2023 17:18
@mateuszrzeszutek mateuszrzeszutek marked this pull request as draft February 6, 2023 09:34
@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review February 7, 2023 14:53
@mateuszrzeszutek
Copy link
Member Author

I'm getting some Vaadin failures on CI that I cannot reproduce locally:

org.openqa.selenium.ElementClickInterceptedException: element click intercepted: Element <vaadin-button id="main.button" tabindex="0" role="button">...</vaadin-button> is not clickable at point (77, 76). Other element would receive the click: <div class="v-system-error" onclick="this.parentElement.removeChild(this)">...</div>

@laurit is it possible that Vaadin tests use the latest possible version of some JS library that was just released today (e.g. this one)?

@laurit
Copy link
Contributor

laurit commented Feb 7, 2023

@mateuszrzeszutek reproduces after ./gradlew :instrumentation:vaadin-14.2:javaagent:clean and rm -rf ~/.pnpm-store/ Probably because frontend compilation fails.

@trask trask added this to the v1.23.0 milestone Feb 9, 2023
@trask trask merged commit ea237e3 into open-telemetry:main Feb 14, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the http-span-name branch February 14, 2023 16:20
@trask trask mentioned this pull request Feb 14, 2023
Merged
trask added a commit that referenced this pull request Feb 14, 2023
@trask
Fix play smoke test (#7819)
62267fd 
resolves #7813

caused by conflict between #7730 and #7801
@rapphil rapphil mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mateuszrzeszutek @laurit @trask